208 lines
13 KiB
Python
208 lines
13 KiB
Python
from django.contrib.auth import get_user_model
|
|
from django.test import TestCase, override_settings
|
|
from django.core.exceptions import ValidationError
|
|
from django.urls import reverse
|
|
from django.http import HttpResponse
|
|
from django.utils import timezone
|
|
from unittest.mock import patch
|
|
from .models import Activity, Card, CardRevision, Membership, Profile
|
|
from .forms import ProfileForm
|
|
from .middleware import ProfileTimezoneMiddleware
|
|
from .services import RevisionConflict, bulk_update_cards, card_for, create_card, create_project, move_card, update_card, update_column
|
|
|
|
|
|
class ProjectWorkflowTests(TestCase):
|
|
def setUp(self):
|
|
users = get_user_model()
|
|
self.owner = users.objects.create_user('owner', password='test-password')
|
|
self.other = users.objects.create_user('other', password='test-password')
|
|
self.project = create_project(self.owner, name='BoomCast', git_repository_url='https://example.com/repo')
|
|
|
|
def test_default_card_and_revision_conflict(self):
|
|
card = create_card(self.owner, self.project, title='Field notes', markdown='# Notes\n\n```py\nprint(1)\n```')
|
|
self.assertEqual(card.priority, 'medium')
|
|
self.assertTrue(card.column.is_default)
|
|
self.assertEqual(CardRevision.objects.get(card=card).markdown, card.description_markdown)
|
|
update_card(self.owner, card, expected_revision=1, description_markdown='# Revised')
|
|
with self.assertRaises(RevisionConflict):
|
|
update_card(self.owner, card, expected_revision=1, description_markdown='# Overwritten')
|
|
self.assertEqual(Card.objects.get(pk=card.pk).description_markdown, '# Revised')
|
|
|
|
def test_idempotent_spec_creation(self):
|
|
first = create_card(self.owner, self.project, title='Spec', markdown='# Exact\n', idempotency_key='client-request-1')
|
|
second = create_card(self.owner, self.project, title='Spec', markdown='# Exact\n', idempotency_key='client-request-1')
|
|
self.assertEqual(first.pk, second.pk)
|
|
with self.assertRaises(ValidationError):
|
|
create_card(self.owner, self.project, title='Different', idempotency_key='client-request-1')
|
|
|
|
def test_access_and_move(self):
|
|
card = create_card(self.owner, self.project, title='A')
|
|
self.assertEqual(self.client.get(reverse('projects:board', args=[self.project.pk])).status_code, 302)
|
|
self.client.force_login(self.other)
|
|
self.assertEqual(self.client.get(reverse('projects:board', args=[self.project.pk])).status_code, 404)
|
|
self.client.force_login(self.owner)
|
|
done = self.project.board.columns.get(is_done=True)
|
|
move_card(self.owner, card, done)
|
|
card.refresh_from_db()
|
|
self.assertIsNotNone(card.completed_at)
|
|
|
|
def test_board_filters_and_escaped_markdown(self):
|
|
card = create_card(self.owner, self.project, title='Danger', markdown='<script>alert(1)</script>\n\n# Safe')
|
|
self.client.force_login(self.owner)
|
|
response = self.client.get(reverse('projects:board', args=[self.project.pk]), {'priority': 'medium'})
|
|
self.assertContains(response, 'Danger')
|
|
response = self.client.get(reverse('projects:board', args=[self.project.pk]), {'priority': 'high'})
|
|
self.assertNotContains(response, 'Danger')
|
|
response = self.client.get(reverse('projects:card', args=[card.pk]))
|
|
self.assertNotContains(response, '<script>alert(1)</script>', html=False)
|
|
self.assertContains(response, '<h1>Safe</h1>', html=False)
|
|
|
|
def test_completion_flag_updates_existing_cards(self):
|
|
card = create_card(self.owner, self.project, title='Complete later')
|
|
column = card.column
|
|
update_column(self.owner, column, is_done=True)
|
|
card.refresh_from_db()
|
|
self.assertIsNotNone(card.completed_at)
|
|
update_column(self.owner, column, is_done=False)
|
|
card.refresh_from_db()
|
|
self.assertIsNone(card.completed_at)
|
|
|
|
def test_preview_sanitizes_script(self):
|
|
self.client.force_login(self.owner)
|
|
response = self.client.post(reverse('projects:preview'), {'description_markdown': '# Hello\n\n<script>alert(1)</script>'})
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertIn('<h1>Hello</h1>', response.content.decode())
|
|
self.assertNotIn('<script>', response.content.decode())
|
|
|
|
def test_preview_renders_read_only_checklist(self):
|
|
self.client.force_login(self.owner)
|
|
response = self.client.post(reverse('projects:preview'), {'description_markdown': '- [ ] Pending\n- [x] Done'})
|
|
self.assertContains(response, '<input type="checkbox" disabled="">', html=False)
|
|
self.assertContains(response, '<input type="checkbox" disabled="" checked="">', html=False)
|
|
|
|
def test_existing_dashboard_requires_login(self):
|
|
self.assertEqual(self.client.get('/').status_code, 302)
|
|
self.client.force_login(self.owner)
|
|
self.assertEqual(self.client.get('/').status_code, 200)
|
|
|
|
def test_profile_timezone_applies_to_requests(self):
|
|
Profile.objects.create(user=self.owner, timezone='America/New_York')
|
|
observed = []
|
|
|
|
def capture(request):
|
|
observed.append(timezone.get_current_timezone_name())
|
|
return HttpResponse('ok')
|
|
|
|
request = type('Request', (), {'user': self.owner})()
|
|
response = ProfileTimezoneMiddleware(capture)(request)
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertEqual(observed, ['America/New_York'])
|
|
self.assertEqual(timezone.get_current_timezone_name(), 'Europe/Amsterdam')
|
|
self.assertFalse(ProfileForm(data={'timezone': 'Not/A_Timezone'}).is_valid())
|
|
|
|
def test_profile_mcp_url_uses_validated_https_origin(self):
|
|
self.client.force_login(self.owner)
|
|
public = 'https://projects.jorendegraaf.eu/mcp'
|
|
headers = {'HTTP_HOST': 'projects.jorendegraaf.eu', 'HTTP_X_FORWARDED_PROTO': 'https'}
|
|
with override_settings(MCP_PUBLIC_URL='https://other.example/mcp'):
|
|
response = self.client.get(reverse('projects:profile'), **headers)
|
|
self.assertEqual(response.context['mcp_url'], public)
|
|
self.assertContains(response, 'This address differs from the configured OAuth resource URL.')
|
|
with override_settings(MCP_PUBLIC_URL=public, OAUTH_ISSUER_URL='https://projects.jorendegraaf.eu/'):
|
|
response = self.client.get(reverse('projects:profile'), **headers)
|
|
self.assertEqual(response.context['mcp_url'], public)
|
|
self.assertNotContains(response, 'This address differs from the configured OAuth resource URL.')
|
|
metadata = self.client.get('/.well-known/oauth-authorization-server', **headers).json()
|
|
self.assertEqual(metadata['issuer'], 'https://projects.jorendegraaf.eu/')
|
|
|
|
with override_settings(MCP_PUBLIC_URL='http://127.0.0.1:8766/mcp'):
|
|
local = self.client.get(reverse('projects:profile'), HTTP_HOST='127.0.0.1:8765')
|
|
self.assertEqual(local.context['mcp_url'], 'http://127.0.0.1:8766/mcp')
|
|
rejected = self.client.get(reverse('projects:profile'), HTTP_HOST='untrusted.example')
|
|
self.assertEqual(rejected.status_code, 400)
|
|
|
|
def test_login_throttles_failed_attempts(self):
|
|
for _ in range(5):
|
|
self.assertEqual(self.client.post('/accounts/login/', {'username': 'owner', 'password': 'wrong'}).status_code, 200)
|
|
self.assertEqual(self.client.post('/accounts/login/', {'username': 'owner', 'password': 'wrong'}).status_code, 429)
|
|
|
|
def test_viewer_can_read_but_cannot_move_or_edit(self):
|
|
Membership.objects.create(project=self.project, user=self.other, role='viewer')
|
|
card = create_card(self.owner, self.project, title='Visible')
|
|
self.client.force_login(self.other)
|
|
response = self.client.get(reverse('projects:board', args=[self.project.pk]))
|
|
self.assertContains(response, 'Visible')
|
|
self.assertNotContains(response, 'New card')
|
|
response = self.client.post(reverse('projects:card_move', args=[card.pk]), {'column_id': str(card.column_id)})
|
|
self.assertEqual(response.status_code, 403)
|
|
|
|
def test_bulk_preview_apply_and_idempotent_retry_for_twenty_cards(self):
|
|
cards = [create_card(self.owner, self.project, title=f'Card {number}') for number in range(21)]
|
|
ids = [str(card.pk) for card in cards]
|
|
revisions = {identifier: 1 for identifier in ids}
|
|
done = self.project.board.columns.get(is_done=True)
|
|
changes = {'column_id': str(done.pk), 'priority': 'high'}
|
|
preview = bulk_update_cards(self.owner, self.project, ids, revisions, changes, dry_run=True)
|
|
self.assertEqual(preview['changed_count'], 21)
|
|
self.assertEqual(CardRevision.objects.filter(card__in=cards).count(), 21)
|
|
result = bulk_update_cards(self.owner, self.project, ids, revisions, changes, idempotency_key='bulk-21')
|
|
self.assertEqual(result['changed_count'], 21)
|
|
self.assertEqual(Card.objects.filter(pk__in=ids, column=done, priority='high', revision=2).count(), 21)
|
|
self.assertEqual(CardRevision.objects.filter(card__in=cards).count(), 42)
|
|
self.assertEqual(Activity.objects.filter(card__in=cards, action='card.bulk_updated').count(), 21)
|
|
self.assertEqual(bulk_update_cards(self.owner, self.project, ids, revisions, changes, idempotency_key='bulk-21'), result)
|
|
self.assertEqual(Activity.objects.filter(card__in=cards, action='card.bulk_updated').count(), 21)
|
|
|
|
def test_bulk_rejects_duplicates_conflicts_cross_project_and_invalid_field(self):
|
|
first = create_card(self.owner, self.project, title='First')
|
|
second = create_card(self.owner, self.project, title='Second')
|
|
another = create_project(self.owner, name='Other board')
|
|
foreign = create_card(self.owner, another, title='Foreign')
|
|
ids = [str(first.pk), str(second.pk)]
|
|
revisions = {identifier: 1 for identifier in ids}
|
|
with self.assertRaises(ValidationError):
|
|
bulk_update_cards(self.owner, self.project, ids + ids[:1], revisions, {'priority': 'high'})
|
|
with self.assertRaises(ValidationError):
|
|
bulk_update_cards(self.owner, self.project, ids, {ids[0]: 0, ids[1]: 1}, {'priority': 'high'})
|
|
with self.assertRaises(ValidationError):
|
|
bulk_update_cards(self.owner, self.project, ids + [str(foreign.pk)], revisions, {'priority': 'high'})
|
|
with self.assertRaises(ValidationError):
|
|
bulk_update_cards(self.owner, self.project, ids, revisions, {'priority': 'high', 'tag_ids': [9999]})
|
|
self.assertEqual(Card.objects.filter(pk__in=ids, priority='medium').count(), 2)
|
|
|
|
def test_bulk_web_preview_and_apply(self):
|
|
card = create_card(self.owner, self.project, title='For bulk edit')
|
|
self.client.force_login(self.owner)
|
|
url = reverse('projects:cards_bulk_edit', args=[self.project.pk])
|
|
self.assertContains(self.client.get(url, {'card': str(card.pk)}), 'For bulk edit')
|
|
data = {'card': [str(card.pk)], 'expected_revisions': __import__('json').dumps({str(card.pk): 1}),
|
|
'change_priority': '1', 'priority': 'high', 'action': 'preview'}
|
|
response = self.client.post(url, data)
|
|
self.assertContains(response, 'Apply changes to 1 card')
|
|
card.refresh_from_db(); self.assertEqual(card.priority, 'medium')
|
|
data.update({'action': 'apply', 'preview_token': response.context['preview_token'], 'idempotency_key': 'web-bulk-1'})
|
|
self.assertContains(self.client.post(url, data), 'Updated 1 card')
|
|
card.refresh_from_db(); self.assertEqual(card.priority, 'high')
|
|
|
|
def test_bulk_rolls_back_if_a_write_fails(self):
|
|
cards = [create_card(self.owner, self.project, title=title) for title in ('A', 'B')]
|
|
ids = [str(card.pk) for card in cards]
|
|
revisions = {identifier: 1 for identifier in ids}
|
|
original = Activity.objects.create
|
|
calls = 0
|
|
|
|
def fail_on_second_bulk_activity(*args, **kwargs):
|
|
nonlocal calls
|
|
if kwargs.get('action') == 'card.bulk_updated':
|
|
calls += 1
|
|
if calls == 2:
|
|
raise RuntimeError('Simulated activity storage failure')
|
|
return original(*args, **kwargs)
|
|
|
|
with patch.object(Activity.objects, 'create', side_effect=fail_on_second_bulk_activity):
|
|
with self.assertRaises(RuntimeError):
|
|
bulk_update_cards(self.owner, self.project, ids, revisions, {'priority': 'high'}, idempotency_key='rollback-check')
|
|
self.assertEqual(Card.objects.filter(pk__in=ids, priority='medium', revision=1).count(), 2)
|
|
self.assertEqual(CardRevision.objects.filter(card__in=cards).count(), 2)
|
|
self.assertEqual(Activity.objects.filter(card__in=cards, action='card.bulk_updated').count(), 0)
|