latest changes
This commit is contained in:
+209
-6
@@ -1,14 +1,14 @@
|
||||
from django.contrib.auth import get_user_model
|
||||
from django.test import TestCase, override_settings
|
||||
from django.test import TestCase, Client, override_settings
|
||||
from django.core.exceptions import ValidationError
|
||||
from django.urls import reverse
|
||||
from django.http import HttpResponse
|
||||
from django.http import HttpResponse, Http404
|
||||
from django.utils import timezone
|
||||
from unittest.mock import patch
|
||||
from .models import Activity, Card, CardRevision, Membership, Profile
|
||||
from .models import Activity, Card, CardRevision, CardComment, CardAttachment, Column, Membership, Profile, Tag
|
||||
from .forms import ProfileForm
|
||||
from .middleware import ProfileTimezoneMiddleware
|
||||
from .services import RevisionConflict, bulk_update_cards, card_for, create_card, create_project, move_card, update_card, update_column
|
||||
from .services import RevisionConflict, bulk_update_cards, card_for, create_card, create_project, move_card, move_card_to_project, update_card, update_column
|
||||
|
||||
|
||||
class ProjectWorkflowTests(TestCase):
|
||||
@@ -46,17 +46,220 @@ class ProjectWorkflowTests(TestCase):
|
||||
card.refresh_from_db()
|
||||
self.assertIsNotNone(card.completed_at)
|
||||
|
||||
def test_cross_project_move_preserves_identity_and_children_and_maps_project_data(self):
|
||||
destination = create_project(self.owner, name='Destination')
|
||||
card = create_card(self.owner, self.project, title='Keep me', markdown='# Keep this')
|
||||
source_sibling = create_card(self.owner, self.project, title='Source sibling')
|
||||
destination_sibling = create_card(self.owner, destination, title='Destination sibling')
|
||||
original_updated_at = card.updated_at
|
||||
card.assignee = self.other
|
||||
card.save(update_fields=['assignee'])
|
||||
Membership.objects.create(project=destination, user=self.other, role='viewer')
|
||||
comment = CardComment.objects.create(card=card, author=self.owner, body='Progress note')
|
||||
attachment = CardAttachment.objects.create(card=card, comment=comment, file='card-attachments/test.txt',
|
||||
original_filename='test.txt', title='Source file', mime_type='text/plain', byte_size=4, sha256='a' * 64)
|
||||
source_tag = Tag.objects.create(project=self.project, name='Roadmap')
|
||||
target_tag = Tag.objects.create(project=destination, name='roadmap')
|
||||
card.tags.add(source_tag)
|
||||
old_activity = card.activity.first()
|
||||
destination_column = destination.board.columns.get(is_default=True)
|
||||
|
||||
moved, result = move_card_to_project(self.owner, card, destination,
|
||||
target_column=destination_column, expected_revision=card.revision, idempotency_key='move-preserve')
|
||||
|
||||
moved.refresh_from_db()
|
||||
self.assertEqual(moved.pk, card.pk)
|
||||
self.assertEqual(moved.project_id, destination.pk)
|
||||
self.assertEqual(moved.column_id, destination_column.pk)
|
||||
self.assertEqual(moved.position, 1)
|
||||
source_sibling.refresh_from_db()
|
||||
self.assertEqual(source_sibling.position, 0)
|
||||
destination_sibling.refresh_from_db()
|
||||
self.assertEqual(destination_sibling.position, 0)
|
||||
self.assertEqual(moved.revision, card.revision + 1)
|
||||
self.assertEqual(moved.description_markdown, '# Keep this')
|
||||
self.assertEqual(moved.updated_at, original_updated_at)
|
||||
self.assertEqual(moved.assignee_id, self.other.pk)
|
||||
self.assertEqual(list(moved.revisions.order_by('revision').values_list('revision', flat=True)), [1, 2])
|
||||
self.assertEqual(list(moved.tags.all()), [target_tag])
|
||||
self.assertEqual(moved.comments.get(pk=comment.pk).body, 'Progress note')
|
||||
self.assertEqual(moved.attachments.get(pk=attachment.pk).file.name, 'card-attachments/test.txt')
|
||||
old_activity.refresh_from_db()
|
||||
self.assertEqual(old_activity.project_id, destination.pk)
|
||||
self.assertTrue(moved.activity.filter(action='card.moved_project').exists())
|
||||
source_event = Activity.objects.get(project=self.project, action='card.moved_project_out')
|
||||
self.assertEqual(source_event.detail['card_id'], str(card.pk))
|
||||
self.assertEqual(result['source_project_id'], str(self.project.pk))
|
||||
self.assertEqual(result['revision'], moved.revision)
|
||||
|
||||
def test_cross_project_move_clears_invalid_assignee_and_tags_with_warnings(self):
|
||||
destination = create_project(self.owner, name='Destination')
|
||||
card = create_card(self.owner, self.project, title='Transfer')
|
||||
card.assignee = self.other
|
||||
card.save(update_fields=['assignee'])
|
||||
tag = Tag.objects.create(project=self.project, name='Only here')
|
||||
card.tags.add(tag)
|
||||
moved, result = move_card_to_project(self.owner, card, destination, expected_revision=card.revision)
|
||||
self.assertIsNone(moved.assignee_id)
|
||||
self.assertFalse(moved.tags.exists())
|
||||
self.assertEqual(len(result['warnings']), 2)
|
||||
|
||||
def test_cross_project_move_validates_access_column_revision_and_idempotency(self):
|
||||
destination = create_project(self.owner, name='Destination')
|
||||
private_destination = create_project(self.other, name='Private destination')
|
||||
archived_destination = create_project(self.owner, name='Archived destination')
|
||||
archived_destination.archived = True
|
||||
archived_destination.save(update_fields=['archived'])
|
||||
card = create_card(self.owner, self.project, title='Transfer')
|
||||
foreign_column = private_destination.board.columns.get(is_default=True)
|
||||
with self.assertRaises(ValidationError):
|
||||
move_card_to_project(self.owner, card, destination, target_column=foreign_column, expected_revision=1)
|
||||
with self.assertRaises(RevisionConflict):
|
||||
move_card_to_project(self.owner, card, destination, expected_revision=0)
|
||||
with self.assertRaises(Http404):
|
||||
move_card_to_project(self.owner, card, private_destination, expected_revision=1)
|
||||
with self.assertRaises(ValidationError):
|
||||
move_card_to_project(self.owner, card, archived_destination, expected_revision=1)
|
||||
moved, _ = move_card_to_project(self.owner, card, destination, expected_revision=1, idempotency_key='retry-1')
|
||||
replay, result = move_card_to_project(self.owner, card, destination, expected_revision=1, idempotency_key='retry-1')
|
||||
self.assertEqual(replay.pk, moved.pk)
|
||||
self.assertEqual(result['revision'], moved.revision)
|
||||
with self.assertRaises(ValidationError):
|
||||
move_card_to_project(self.owner, card, private_destination, expected_revision=1, idempotency_key='retry-1')
|
||||
|
||||
def test_cross_project_move_ui_requires_csrf_and_shows_success_or_stale_feedback(self):
|
||||
destination = create_project(self.owner, name='Destination')
|
||||
card = create_card(self.owner, self.project, title='Transfer')
|
||||
browser = Client(enforce_csrf_checks=True)
|
||||
browser.force_login(self.owner)
|
||||
detail = browser.get(reverse('projects:card', args=[card.pk]))
|
||||
self.assertContains(detail, 'Move to project')
|
||||
self.assertContains(detail, 'Destination')
|
||||
csrf = browser.cookies['csrftoken'].value
|
||||
move_url = reverse('projects:card_move_project', args=[card.pk])
|
||||
payload = {'target_project_id': str(destination.pk), 'target_column_id': '',
|
||||
'expected_revision': str(card.revision), 'idempotency_key': 'web-move-1'}
|
||||
self.assertEqual(browser.post(move_url, payload).status_code, 403)
|
||||
stale = browser.post(move_url, {**payload, 'expected_revision': '0', 'idempotency_key': 'web-stale'}, HTTP_X_CSRFTOKEN=csrf)
|
||||
self.assertEqual(stale.status_code, 302)
|
||||
stale_detail = browser.get(reverse('projects:card', args=[card.pk]))
|
||||
self.assertContains(stale_detail, 'This card changed before it could be moved.')
|
||||
response = browser.post(move_url, payload, HTTP_X_CSRFTOKEN=csrf)
|
||||
self.assertEqual(response.status_code, 302)
|
||||
self.assertEqual(response['Location'], reverse('projects:card', args=[card.pk]))
|
||||
self.assertEqual(Card.objects.get(pk=card.pk).project_id, destination.pk)
|
||||
self.assertContains(browser.get(reverse('projects:card', args=[card.pk])), 'Moved “Transfer” from BoomCast to Destination.')
|
||||
|
||||
def test_cross_project_move_rolls_back_when_revision_creation_fails(self):
|
||||
destination = create_project(self.owner, name='Destination')
|
||||
card = create_card(self.owner, self.project, title='Transfer')
|
||||
with patch.object(CardRevision.objects, 'create', side_effect=RuntimeError('revision store unavailable')):
|
||||
with self.assertRaises(RuntimeError):
|
||||
move_card_to_project(self.owner, card, destination, expected_revision=card.revision)
|
||||
card.refresh_from_db()
|
||||
self.assertEqual(card.project_id, self.project.pk)
|
||||
self.assertEqual(card.revision, 1)
|
||||
self.assertFalse(Activity.objects.filter(action='card.moved_project_out').exists())
|
||||
|
||||
def test_board_filters_and_escaped_markdown(self):
|
||||
card = create_card(self.owner, self.project, title='Danger', markdown='<script>alert(1)</script>\n\n# Safe')
|
||||
self.client.force_login(self.owner)
|
||||
response = self.client.get(reverse('projects:board', args=[self.project.pk]), {'priority': 'medium'})
|
||||
self.assertContains(response, 'Danger')
|
||||
visible = [card for column in response.context['columns'] for card in column.visible_cards]
|
||||
self.assertEqual([item.pk for item in visible], [card.pk])
|
||||
response = self.client.get(reverse('projects:board', args=[self.project.pk]), {'priority': 'high'})
|
||||
self.assertNotContains(response, 'Danger')
|
||||
visible = [item for column in response.context['columns'] for item in column.visible_cards]
|
||||
self.assertEqual(visible, [])
|
||||
response = self.client.get(reverse('projects:card', args=[card.pk]))
|
||||
self.assertNotContains(response, '<script>alert(1)</script>', html=False)
|
||||
self.assertContains(response, '<h1>Safe</h1>', html=False)
|
||||
|
||||
def test_board_archive_filter_and_mobile_filter_sheet(self):
|
||||
active = create_card(self.owner, self.project, title='Active card')
|
||||
archived = create_card(self.owner, self.project, title='Archived card')
|
||||
archived.archived = True
|
||||
archived.save(update_fields=['archived'])
|
||||
self.client.force_login(self.owner)
|
||||
response = self.client.get(reverse('projects:board', args=[self.project.pk]))
|
||||
visible = [card for column in response.context['columns'] for card in column.visible_cards]
|
||||
self.assertEqual([card.pk for card in visible], [active.pk])
|
||||
self.assertContains(response, 'role="dialog"')
|
||||
self.assertContains(response, 'Show archived cards')
|
||||
response = self.client.get(reverse('projects:board', args=[self.project.pk]), {'archived': '1'})
|
||||
visible = [card for column in response.context['columns'] for card in column.visible_cards]
|
||||
self.assertEqual([card.pk for card in visible], [archived.pk])
|
||||
|
||||
def test_board_progress_is_zero_safe_and_activity_is_human_readable(self):
|
||||
self.client.force_login(self.owner)
|
||||
response = self.client.get(reverse('projects:board', args=[self.project.pk]))
|
||||
self.assertEqual(response.context['progress_percent'], 0)
|
||||
self.assertContains(response, '0 / 0')
|
||||
card = create_card(self.owner, self.project, title='Timeline card')
|
||||
for index in range(5):
|
||||
Activity.objects.create(project=self.project, card=card, actor=self.owner,
|
||||
action='card.moved', detail={'sequence': index})
|
||||
response = self.client.get(reverse('projects:board', args=[self.project.pk]))
|
||||
self.assertEqual(len(response.context['recent_activity']), 3)
|
||||
self.assertGreater(len(response.context['older_activity']), 0)
|
||||
self.assertContains(response, 'moved a card')
|
||||
self.assertContains(response, 'View all')
|
||||
|
||||
def test_card_detail_uses_responsive_layout_and_readable_history(self):
|
||||
card = create_card(self.owner, self.project, title='Detail view card', markdown='# Description\n\nCard detail text.')
|
||||
self.client.force_login(self.owner)
|
||||
response = self.client.get(reverse('projects:card', args=[card.pk]))
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertContains(response, 'projects/card_detail.css')
|
||||
self.assertContains(response, 'Description')
|
||||
self.assertContains(response, 'Card info')
|
||||
self.assertContains(response, 'Progress notes')
|
||||
self.assertContains(response, 'View raw Markdown')
|
||||
self.assertContains(response, 'created this card')
|
||||
self.assertContains(response, 'Edit card')
|
||||
self.assertContains(response, 'Add a progress note')
|
||||
|
||||
def test_card_detail_preserves_viewer_read_only_permissions(self):
|
||||
card = create_card(self.owner, self.project, title='Viewer detail card', markdown='Readable for the team.')
|
||||
Membership.objects.create(project=self.project, user=self.other, role='viewer')
|
||||
self.client.force_login(self.other)
|
||||
response = self.client.get(reverse('projects:card', args=[card.pk]))
|
||||
self.assertContains(response, 'Readable for the team.')
|
||||
self.assertContains(response, 'Card info')
|
||||
self.assertNotContains(response, 'Edit card')
|
||||
self.assertNotContains(response, 'Add a progress note')
|
||||
self.assertNotContains(response, 'Add card files')
|
||||
|
||||
def test_projects_index_preserves_search_access_and_archived_view(self):
|
||||
finished = create_card(self.owner, self.project, title='Searchable milestone')
|
||||
move_card(self.owner, finished, self.project.board.columns.get(is_done=True))
|
||||
archived_card = create_card(self.owner, self.project, title='Old milestone')
|
||||
archived_card.archived = True
|
||||
archived_card.save(update_fields=['archived'])
|
||||
private_project = create_project(self.other, name='Private workspace')
|
||||
self.client.force_login(self.owner)
|
||||
url = reverse('projects:list')
|
||||
response = self.client.get(url)
|
||||
self.assertContains(response, 'projects/project_list.css')
|
||||
self.assertContains(response, 'BoomCast')
|
||||
self.assertNotContains(response, 'Private workspace')
|
||||
project = next(item for item in response.context['projects'] if item.pk == self.project.pk)
|
||||
self.assertEqual(project.card_count, 2)
|
||||
self.assertEqual(project.active_card_count, 1)
|
||||
self.assertEqual(project.done_card_count, 1)
|
||||
self.assertEqual(project.progress_percent, 100)
|
||||
response = self.client.get(url, {'q': 'Searchable'})
|
||||
self.assertContains(response, 'BoomCast')
|
||||
self.assertContains(response, 'Open board')
|
||||
response = self.client.get(url, {'q': 'Searchable'}, HTTP_HX_REQUEST='true')
|
||||
self.assertContains(response, 'BoomCast')
|
||||
self.assertEqual(response.context['query'], 'Searchable')
|
||||
self.project.archived = True
|
||||
self.project.save(update_fields=['archived'])
|
||||
response = self.client.get(url, {'archived': '1'})
|
||||
self.assertContains(response, 'Archived')
|
||||
self.assertContains(response, 'BoomCast')
|
||||
self.assertNotContains(response, 'Private workspace')
|
||||
|
||||
def test_completion_flag_updates_existing_cards(self):
|
||||
card = create_card(self.owner, self.project, title='Complete later')
|
||||
column = card.column
|
||||
|
||||
Reference in New Issue
Block a user