latest changes
This commit is contained in:
+73
-2
@@ -4,10 +4,11 @@ from django.core.exceptions import ValidationError
|
||||
from django.urls import reverse
|
||||
from django.http import HttpResponse
|
||||
from django.utils import timezone
|
||||
from .models import Card, CardRevision, Membership, Profile
|
||||
from unittest.mock import patch
|
||||
from .models import Activity, Card, CardRevision, Membership, Profile
|
||||
from .forms import ProfileForm
|
||||
from .middleware import ProfileTimezoneMiddleware
|
||||
from .services import RevisionConflict, card_for, create_card, create_project, move_card, update_card, update_column
|
||||
from .services import RevisionConflict, bulk_update_cards, card_for, create_card, create_project, move_card, update_card, update_column
|
||||
|
||||
|
||||
class ProjectWorkflowTests(TestCase):
|
||||
@@ -134,3 +135,73 @@ class ProjectWorkflowTests(TestCase):
|
||||
self.assertNotContains(response, 'New card')
|
||||
response = self.client.post(reverse('projects:card_move', args=[card.pk]), {'column_id': str(card.column_id)})
|
||||
self.assertEqual(response.status_code, 403)
|
||||
|
||||
def test_bulk_preview_apply_and_idempotent_retry_for_twenty_cards(self):
|
||||
cards = [create_card(self.owner, self.project, title=f'Card {number}') for number in range(21)]
|
||||
ids = [str(card.pk) for card in cards]
|
||||
revisions = {identifier: 1 for identifier in ids}
|
||||
done = self.project.board.columns.get(is_done=True)
|
||||
changes = {'column_id': str(done.pk), 'priority': 'high'}
|
||||
preview = bulk_update_cards(self.owner, self.project, ids, revisions, changes, dry_run=True)
|
||||
self.assertEqual(preview['changed_count'], 21)
|
||||
self.assertEqual(CardRevision.objects.filter(card__in=cards).count(), 21)
|
||||
result = bulk_update_cards(self.owner, self.project, ids, revisions, changes, idempotency_key='bulk-21')
|
||||
self.assertEqual(result['changed_count'], 21)
|
||||
self.assertEqual(Card.objects.filter(pk__in=ids, column=done, priority='high', revision=2).count(), 21)
|
||||
self.assertEqual(CardRevision.objects.filter(card__in=cards).count(), 42)
|
||||
self.assertEqual(Activity.objects.filter(card__in=cards, action='card.bulk_updated').count(), 21)
|
||||
self.assertEqual(bulk_update_cards(self.owner, self.project, ids, revisions, changes, idempotency_key='bulk-21'), result)
|
||||
self.assertEqual(Activity.objects.filter(card__in=cards, action='card.bulk_updated').count(), 21)
|
||||
|
||||
def test_bulk_rejects_duplicates_conflicts_cross_project_and_invalid_field(self):
|
||||
first = create_card(self.owner, self.project, title='First')
|
||||
second = create_card(self.owner, self.project, title='Second')
|
||||
another = create_project(self.owner, name='Other board')
|
||||
foreign = create_card(self.owner, another, title='Foreign')
|
||||
ids = [str(first.pk), str(second.pk)]
|
||||
revisions = {identifier: 1 for identifier in ids}
|
||||
with self.assertRaises(ValidationError):
|
||||
bulk_update_cards(self.owner, self.project, ids + ids[:1], revisions, {'priority': 'high'})
|
||||
with self.assertRaises(ValidationError):
|
||||
bulk_update_cards(self.owner, self.project, ids, {ids[0]: 0, ids[1]: 1}, {'priority': 'high'})
|
||||
with self.assertRaises(ValidationError):
|
||||
bulk_update_cards(self.owner, self.project, ids + [str(foreign.pk)], revisions, {'priority': 'high'})
|
||||
with self.assertRaises(ValidationError):
|
||||
bulk_update_cards(self.owner, self.project, ids, revisions, {'priority': 'high', 'tag_ids': [9999]})
|
||||
self.assertEqual(Card.objects.filter(pk__in=ids, priority='medium').count(), 2)
|
||||
|
||||
def test_bulk_web_preview_and_apply(self):
|
||||
card = create_card(self.owner, self.project, title='For bulk edit')
|
||||
self.client.force_login(self.owner)
|
||||
url = reverse('projects:cards_bulk_edit', args=[self.project.pk])
|
||||
self.assertContains(self.client.get(url, {'card': str(card.pk)}), 'For bulk edit')
|
||||
data = {'card': [str(card.pk)], 'expected_revisions': __import__('json').dumps({str(card.pk): 1}),
|
||||
'change_priority': '1', 'priority': 'high', 'action': 'preview'}
|
||||
response = self.client.post(url, data)
|
||||
self.assertContains(response, 'Apply changes to 1 card')
|
||||
card.refresh_from_db(); self.assertEqual(card.priority, 'medium')
|
||||
data.update({'action': 'apply', 'preview_token': response.context['preview_token'], 'idempotency_key': 'web-bulk-1'})
|
||||
self.assertContains(self.client.post(url, data), 'Updated 1 card')
|
||||
card.refresh_from_db(); self.assertEqual(card.priority, 'high')
|
||||
|
||||
def test_bulk_rolls_back_if_a_write_fails(self):
|
||||
cards = [create_card(self.owner, self.project, title=title) for title in ('A', 'B')]
|
||||
ids = [str(card.pk) for card in cards]
|
||||
revisions = {identifier: 1 for identifier in ids}
|
||||
original = Activity.objects.create
|
||||
calls = 0
|
||||
|
||||
def fail_on_second_bulk_activity(*args, **kwargs):
|
||||
nonlocal calls
|
||||
if kwargs.get('action') == 'card.bulk_updated':
|
||||
calls += 1
|
||||
if calls == 2:
|
||||
raise RuntimeError('Simulated activity storage failure')
|
||||
return original(*args, **kwargs)
|
||||
|
||||
with patch.object(Activity.objects, 'create', side_effect=fail_on_second_bulk_activity):
|
||||
with self.assertRaises(RuntimeError):
|
||||
bulk_update_cards(self.owner, self.project, ids, revisions, {'priority': 'high'}, idempotency_key='rollback-check')
|
||||
self.assertEqual(Card.objects.filter(pk__in=ids, priority='medium', revision=1).count(), 2)
|
||||
self.assertEqual(CardRevision.objects.filter(card__in=cards).count(), 2)
|
||||
self.assertEqual(Activity.objects.filter(card__in=cards, action='card.bulk_updated').count(), 0)
|
||||
|
||||
Reference in New Issue
Block a user